Skip to content

Create hero #10

Jump to bottom
Merged
merged 6 commits into from
Sep 14, 2026
Merged

Create hero #10

merged 6 commits into from
Sep 14, 2026
+117 −11

Conversation

minael
Copy link
Member

@minael minael commented Sep 12, 2026 •
edited by emmafre
Loading

Add a responsive hero section for the home page with the Rick and Morty logo, introductory text, a Read more link, and character image. The layout is also responsive.

Closes #3

@minael minael added this to the P1 milestone Sep 12, 2026
@minael minael self-assigned this Sep 12, 2026
@minael minael requested a review from a team as a code owner September 12, 2026 20:05
karenska
karenska requested changes Sep 12, 2026
View reviewed changes
Copy link
Member

@karenska karenska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but take a look at my comment in the code. I couldn’t open the project in the browser, so I wasn’t able to review the visual result.

@minael minael requested a review from karenska September 12, 2026 21:13
karenska
karenska approved these changes Sep 12, 2026
View reviewed changes
Copy link
Member

@karenska karenska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the changes you made to the first draft. Great work, Mina!

emmafre
emmafre approved these changes Sep 14, 2026
View reviewed changes
Copy link
Member

@emmafre emmafre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Page is responsive and the code is clean

gurveers
gurveers approved these changes Sep 14, 2026
View reviewed changes
Copy link
Member

@gurveers gurveers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, keep up the good work!

@minael minael merged commit d55b7f3 into dev Sep 14, 2026
@emmafre emmafre deleted the 3-create-hero branch September 14, 2026 14:23
@emmafre emmafre changed the title 3 create hero Create hero Sep 16, 2026
@minael minael linked an issue Sep 16, 2026 that may be closed by this pull request
Create hero #3
Closed
4 tasks
Sign in to join this conversation on GitHub.
Reviewers

@karenska karenska karenska approved these changes

@emmafre emmafre emmafre approved these changes

@gurveers gurveers gurveers approved these changes

Assignees

@minael minael

Labels
None yet
Projects
None yet
Milestone
P1
Development

Successfully merging this pull request may close these issues.

Create hero
4 participants
@minael @karenska @emmafre @gurveers